Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check adminRepoCreationOnly #177

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Jan 3, 2025

Main Changes

  • Enable check adminRepoCreationOnly in the compliance_checks table (b14821b)
  • Add check validator for adminRepoCreationOnly (fdd8199)
  • Add check adminRepoCreationOnly (0c8b874)

Other Changes

  • Revert boolean logic to match validation criteria (fb7996c)

Context

Close #75

Changelog

Copy link

github-actions bot commented Jan 3, 2025

It looks like you've made changes to the migrations. Thanks for your contribution!

  • Have you run npm run db:generate-schema to ensure the updated schemas are included in your PR?
  • Have you run npm run db:migrate and then npm run db:rollback to confirm that rollbacks are working as expected?

Note: Please avoid making changes to existing migration files, as they won't be executed again in deployed environments.

Copy link

github-actions bot commented Jan 3, 2025

It looks like you've made changes to the compliance checks. Thanks for your contribution!
Here are some questions to ensure your changes are complete. Please feel free to ignore the ones that are not relevant:

  • Have you run npm run db:generate-schema to ensure the updated schemas are included in your PR?
  • Have you run npm run db:migrate and then npm run db:rollback to confirm that rollbacks are working as expected?
  • Have you updated the compliance check in the compliance_checks table?
  • Have you included a specific validator (src/checks/validators/) for this check with unit tests (__tests__/checks/)?
  • Have you included a specific file in src/checks/complianceChecks with the integration tests (__tests__/checks/)?
  • Have you included severity validation (getSeverityFromPriorityGroup)?
  • Have you included the tasks, alerts, and results in the database tables?
  • Have you tested the check with check run --name {check_code_name} using the seeded database (npm run db:seed)?
  • Have you created a PR in the website with the calculation details?

You can find more information in the contributing guide.

@UlisesGascon UlisesGascon self-assigned this Jan 3, 2025
@UlisesGascon UlisesGascon marked this pull request as ready for review January 3, 2025 16:10
@UlisesGascon UlisesGascon merged commit 775d19e into main Jan 3, 2025
5 checks passed
@UlisesGascon UlisesGascon deleted the feat/adminRepoCreationOnly branch January 3, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Compliance check: adminRepoCreationOnly
1 participant