First shot at code style stuff #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
References #75 |
slime73
reviewed
Nov 23, 2021
slime73
reviewed
Nov 23, 2021
Cheeseness
reviewed
Nov 23, 2021
uberlinuxguy
commented
Nov 23, 2021
Member
|
I just wanna test this out locally (later today hopefully) to make sure it doesn't cause any unexpected issues for me |
uberlinuxguy
commented
Nov 23, 2021
Member
Author
|
Are we good to merge this as a starting point? |
Member
|
Go ahead and merge it IMO, if we run into any issues we can figure things out from there |
Contributor
|
Why not use end_of_line = auto |
uberlinuxguy
commented
Dec 8, 2021
Comment on lines
+6
to
+8
| # Unix-style newlines with a newline ending every file | ||
| [*] | ||
| end_of_line = lf |
Member
Author
There was a problem hiding this comment.
Suggested change
| # Unix-style newlines with a newline ending every file | |
| [*] | |
| end_of_line = lf |
Remove local enforcement of line endings in favor of enforcing what goes into the repo via .gitattributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first start at some code style stuff, until we codify something. Probably want a README update too.