Conversation
Build pinned OMEdit navigation tests, run the two LSP tests under Xvfb, and retain JUnit results and failure diagnostics. Keep the existing fast Qt protocol job. Co-authored-by: JKRT <jtinnerholm@gmail.com>
Include the OMEdit coding-style corrections in the GUI job. Install system minizip, expat and zlib development packages required by the pinned compiler dependencies; CI stopped at the minizip header check. Co-authored-by: JKRT <jtinnerholm@gmail.com>
Contributor
Author
|
Following the coding-style discussion with JKRT, updated the OMEdit pin to af6e22a11ee3936bc27cbac56448d6e611a25d0f so CI exercises the corrected test layout and naming. Also added the system minizip, expat and zlib development dependencies: the first clean CI run stopped at the missing unzip.h check. Actionlint passes, and the runner passes both tests against the rebuilt local checkout. The clean CI build still needs verification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is JKRT_AGENTIC_ACCOUNT.
Run the real OMEdit editor navigation tests against the language-server revision being reviewed, so an incompatible definition response is caught beyond the existing Qt protocol harness.
The new workflow builds a pinned OpenModelica revision and runs only
LanguageServerandLanguageServerNavigationunder Xvfb. This covers Ctrl+click navigation to the returned declaration, navigation without a client, and an empty-definition response followed by a successful request on the same client. The latter case uses the controlled fixture from OpenModelica; the positive GUI case uses the freshly built server from this repository.Depends on OpenModelica/OpenModelica#17007 and relates to #90. The OpenModelica commit is pinned explicitly; merge that PR first and update the pin if its final SHA changes. This does not close the issue automatically.
The job runs for server/test/workflow changes on PRs and main, with manual dispatch available. It requires both test registrations, has bounded execution without retries, and uploads JUnit, revision/version metadata, screenshots and logs. It keeps the fast Qt compatibility job and is initially separate from release publication dependencies. Building the compiler and GUI is expensive even though only two tests run; compilation uses two workers and a cache, with a 90-minute job limit.
Validation:
actionlint, Bash syntax validation andgit diff --checkpass.omcinstall component staged separately.Opening as a draft until the clean CI build is verified and the companion OpenModelica PR is ready.