Repository navigation
Conversation
…ce filter removed The reference-header filter went to OM.simulate only, after the backend phase's translate, so it never applied (no reference signal was missing without it). A registry filter now goes to both phases, as OM.simulate translates again for another filter. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runner: a registry
observedFiltergoes to bothOM.translateandOM.simulate, and the reference-header filter is removed.The header filter went to the simulate only, after the backend phase's translate, so it never applied (no reference signal was missing without it). OM.jl's
simulateby name now translates again for another filter (JKRT/OM.jl#80), which would have translated every coverage model twice.Merge after OpenModelica/OMBackend.jl#95, before or with JKRT/OM.jl#80. Tests: 156/156.
🤖 Generated with Claude Code