Repository navigation
Event re-solve: Newton with the problem's Jacobian first (0.7.1) - #89
Merged
Merged
Conversation
At an event, the algebraic rows of a mass-matrix problem are solved by Newton with the problem's own Jacobian (the algebraic block, factorized sparse) before BrownFullBasicInit. At a flow reversal BrownFullBasicInit's finite-difference Jacobian straddles a relation without an event; MSL Fluid MeasuringTemperature simulated 241 s, now 24 s. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At an event, the algebraic rows of a mass-matrix problem are re-solved by Newton with the problem's own Jacobian (the algebraic block, factorized sparse) before BrownFullBasicInit, which stays the fallback. At a flow reversal BrownFullBasicInit's finite-difference Jacobian straddles a relation without an event: MSL Fluid MeasuringTemperature spent 218 of 243 s in event re-solves; it now simulates in 24 s and validates.
Tests: the reduced flow reversal (BrownFullBasicInit 1015 right-hand side calls, Newton 4); a 3000-row algebraic block re-solved sparse.
Checked locally: tests 552/552; OM.jl tests pass (6 broken); OMLibraryTesting tests and smoke pass. MSL validate 3.2.3 351/425, 4.1.0 442/534 (before: 349, 441); simulate time 0.98x and 0.90x.
Version 0.7.1.
🤖 Generated with Claude Code