String(): format with Printf, not C's snprintf (Windows) - 0.5.2 - #80
Merged
Merged
Conversation
Windows exports no snprintf symbol (the Universal CRT defines it inline): modelica_String(r, significantDigits, minimumLength, leftJustified) and modelica_String(r, format) threw "could not load symbol snprintf" there (8 errors in modelicaBuiltinsTests on master's Windows CI). Printf takes the same C conversions; a `*.*` width and precision are written into the format. 376/376. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OMBackend's own CI on master failed on Windows after the 1.13 release merge (macOS and Linux green): 8 errors in
modelicaBuiltinsTests.jl, allcould not load symbol "snprintf".Windows exports no
snprintfsymbol (the Universal CRT defines it inline), somodelica_String(r, significantDigits, minimumLength, leftJustified)andmodelica_String(r, format)(Modelica'sStringat run time) threw there._cFormatnow formats with Julia'sPrintf, which takes the same C conversions; a*.*width and precision are written into the format. Same fix as OMFrontend'sString()of constants in the release.🤖 Generated with Claude Code