Repository navigation
feat(fonts): add Chiron GoRound TC as a Traditional Chinese fallback - #81
Merged
Merged
Conversation
Rounds out the script-fallback set (Korean, Simplified Chinese, Arabic) with Traditional Chinese. Placed ahead of Noto Sans SC in the fallback stack so a character both fonts can draw still comes out in traditional-style forms rather than simplified ones. Verified end-to-end: downloads, registers and draws correctly for Traditional-Chinese-specific text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the automatic script-fallback set with Traditional Chinese coverage.
Fonts — added:
Chiron GoRound TC, a Traditional Chinese font, added to the fallback-only catalogue (FONT_CATALOGUE_FALLBACK_ONLY) and toDEFAULT_FONT_FAMILIES. Verified it actually resolves through the Google Fonts CSS API before adding it — this package can only fetch fonts Google Fonts itself serves.Noto Sans SCin the fallback stack, so a character both fonts can draw still comes out in traditional-style forms rather than simplified ones (Skia resolves the stack per glyph, so order only matters where two fallback fonts overlap).--no-fallbackhelp text and the README's font sections (default list, catalogue table,installsample output,--no-fallbackdescription) to mention it alongside the existing three.Fonts — considered but not added: a few other script-fallback candidates (covering Simplified Chinese, Egyptian hieroglyphs, and general Unicode fallback) turned out not to be distributed through Google Fonts, so they don't fit this package's fonts-only-from-Google-Fonts model — the whole point of resolving fonts by name through the Google Fonts CSS API is that it doubles as the licence check (see
googleFonts.ts).Themes — no changes: after comparing against the current named color-theme catalogue (
COLOR_THEME_CATALOGUE, 21 entries), nothing new to add — the palette this package already ships matches it in full.Verified end-to-end (not just the catalogue wiring): rendered Traditional-Chinese-specific text with a clean font cache and confirmed
Chiron GoRound TCdownloads, registers, and draws the glyphs correctly rather than falling through to tofu or a simplified-style substitute.Test plan
npm run typechecknpm run ci(Biome)npm run test(786 tests, incl. 2 new ones covering the fallback-catalogue and ordering)Chiron GoRound TCdownloads and renders correctly