Fixed incorrect container port and mapped folder within container#25
Merged
ryecoaaron merged 1 commit intoOpenMediaVault-Plugin-Developers:masterfrom Dec 23, 2024
yantex0:patch-1
Merged
Fixed incorrect container port and mapped folder within container#25ryecoaaron merged 1 commit intoOpenMediaVault-Plugin-Developers:masterfrom yantex0:patch-1
ryecoaaron merged 1 commit intoOpenMediaVault-Plugin-Developers:masterfrom
yantex0:patch-1
Conversation
- Changed container_name to be lowercase, same as most other omv compose containers - As omv compose examples are primarily for newcomers, have provided more explanation about uncommenting the volume line and mapping line. -Changed the mapping line, the host directory isn't in line with other omv compose syntax for data folder. Container directory is the incorrect directory, the conf.yml needs to be in /app/user-data or it does nothing. -Container port number is incorrect, the container by default listens on 8080, not 80. So it isn't reachable, just another thing newcomers have to troubleshoot for no reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed container_name to be lowercase, same as most other omv compose containers
As omv compose examples are primarily for newcomers, have provided more explanation about uncommenting the volume line and mapping line.
Changed the mapping line, the host directory isn't in line with other omv compose syntax for data folder. Container directory is the incorrect directory, the conf.yml needs to be in /app/user-data or it does nothing.
Container port number is incorrect, the container by default listens on 8080, not 80. So it isn't reachable, just another thing newcomers have to troubleshoot for no reason.