Removed old install scripts #4774
Open
+0
−59,224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: PayPal
github-actions
bot
added
Component: Bundle
|
sreichel
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request removes obsolete database migration/upgrade files that are no longer required for versions below v1.6. The cleanup targets install scripts for the Directory, Dataflow, and Customer modules that were used for older version upgrades.
- Removes install and upgrade SQL scripts for Directory module below v0.8.3
- Removes install and upgrade SQL scripts for Dataflow module below v1.6.0.0
- Removes install and upgrade SQL scripts for Customer module below v1.6.0.0
Reviewed Changes
Copilot reviewed 282 out of 596 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/code/core/Mage/Directory/sql/directory_setup/*.php | Removed obsolete Directory module installation/upgrade scripts |
| app/code/core/Mage/Dataflow/sql/dataflow_setup/*.php | Removed obsolete Dataflow module installation/upgrade scripts |
| app/code/core/Mage/Customer/sql/customer_setup/*.php | Removed obsolete Customer module installation/upgrade scripts |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sreichel
force-pushed
the
installer-clenup
branch
from
c6ba4b6 to
8251136
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Install scripts below v1.6 are not requiered anymore.
Manual testing scenarios (*)
ddev export-db -f test-before.sql.gzipddev export-db -f test-after.sql.gzip