fix(onedrive): direct upload small file error #279
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenListTeam/OpenList#1668
Description / 描述
file.size > chunkSizecheck in the Frontend.Motivation and Context / 背景
Relates to #249
When uploading files (
size <= ChunkSize), server side usesupBiglogic (for chunked upload) to request for the upload url, therefore the PUT request needs a headerContent-Range.But in frontend
uploadSingledon't specify this header. CausingUpload failed with status 400.{"error":{"code":"invalidRequest","message":"The Content-Range header is missing or malformed."}}How Has This Been Tested? / 测试
0 <
smallFileLimit(e.g. 4mb) < defaultChunkSize(e.g. 5mb)So there are 3 situations:
3.5mb: Client receivesChunkSize = 0and usesuploadSingle(1 PUT request)4.5mb: Client receivesChunkSize > 0and usesuploadChunkbutChunkCount = 1(1 PUT request)5.5mb: Client receivesChunkSize > 0and usesuploadChunkbutChunkCount > 1(multiple PUT requests)Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库(若适用)。