feat(fs): Add new folder creation button in copy/move dialog #255
+177
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrgzs
added
enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds inline folder creation functionality to the folder tree component used in copy/move dialogs. Users can now create new folders directly within the destination folder selection modal without leaving the current workflow.
Key changes:
- Added a "Create Folder" button in the modal header that triggers inline folder creation
- Implemented
FolderNameInputcomponent with keyboard navigation (Enter to submit, Escape to cancel) - Extended
FolderTreeHandlerinterface to support triggering folder creation from parent components
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/components/FolderTree.tsx | Adds FolderNameInput component for inline folder creation, extends context and handler interface to support creation workflow, adds headerSlot prop to ModalFolderChoose |
| src/pages/home/toolbar/CopyMove.tsx | Adds CreateFolderButton component and integrates it into Copy and Move modals via the new headerSlot prop |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: jenfonro <[email protected]>
Signed-off-by: jenfonro <[email protected]>
Contributor
Author
|
@xrgzs 没什么问题的话就可以合并了吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / 描述
在复制/移动选择框中增加
新建文件夹按钮Motivation and Context / 背景
现版本在复制/移动时如果需要新文件夹,那么需要先手动到该目录新建目录,再进行该操作
新增后可以方便添加
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库（若适用）。