Skip to content

Implement RAG Chat #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: gkwan-ibm-rag
Choose a base branch
from
Open

Implement RAG Chat #41

wants to merge 18 commits into from

Conversation

SiaaG-dev
Copy link
Member

address #21

Siaa Gor and others added 15 commits July 24, 2025 10:46
implemented groups with read/write (admin) and read only (user) access
eabb864 
Signed-off-by: Siaa Gor <[email protected]>
updated pom.xml
1b97d64 
Signed-off-by: Siaa Gor <[email protected]>
resolving spacing difference for files changed in embedding service.java
73c503b 
Signed-off-by: Siaa Gor <[email protected]>
@gkwan-ibm
dev content review
9c97b97 
Signed-off-by: Gilbert Kwan <[email protected]>
@gkwan-ibm
dev content review
6156e70 
Signed-off-by: Gilbert Kwan <[email protected]>
stashed changes but merging to test- work in progress
29eb595 
Signed-off-by: Siaa Gor <[email protected]>
implemented and tested Loading the embeddings from the text segments …
bb9e6d1 
…to the Mongodb Database using the Api calls defined in EmbeddingService.java. Also added an api in EmbeddingService.java to retrieve all embeddings. 1. user visits localhost:8080 the chat service -> All the files under knowledge_base are added to Mongodb 2. OpenApi ui, users are able to call the get method to see all embeddings from the database.

Signed-off-by: Siaa Gor <[email protected]>
Implemented and tested comparing embeddings/ getting top 3 content an…
9b76ebb 
…d coding the custom retrival augmentator - example query on localhost:9080 : Create Java class that uses the MicroProfile Health API to check/montior CPU usage is below 95%:

and comparing to mp-health-3.txt.
Also increase character length size for segments to keep simple

Signed-off-by: Siaa Gor <[email protected]>
@GeeTransit
Remove Hugging Face support (#38)
7d7cc10 
Hugging Face models do not support streaming chat anyways
@AndrewSasmito @gkwan-ibm
Remove HuggingFace support (#37)
a8a6677 
* Fix packaging, toolchat.js, readme, pom

Signed-off-by: Andrew Sasmito <[email protected]>

* Add Google Gemini support, remove HF

Signed-off-by: Andrew Sasmito <[email protected]>

* Remove HF from the tests, add Gemini

Signed-off-by: Andrew Sasmito <[email protected]>

* Update readme

Signed-off-by: Andrew Sasmito <[email protected]>

* Remove gemini

Signed-off-by: Andrew Sasmito <[email protected]>

* Remove gemini from readme

Signed-off-by: Andrew Sasmito <[email protected]>

* Remove gemini from pom

Signed-off-by: Andrew Sasmito <[email protected]>

* dev content review

Signed-off-by: Gilbert Kwan <[email protected]>

---------

Signed-off-by: Andrew Sasmito <[email protected]>
Signed-off-by: Gilbert Kwan <[email protected]>
Co-authored-by: Andrew Sasmito <[email protected]>
Co-authored-by: Gilbert Kwan <[email protected]>
finalizing resource folder changes
914a806 
Signed-off-by: Siaa Gor <[email protected]>
work in progress for unit tests - and added more txt files
78a01d2 
Signed-off-by: Siaa Gor <[email protected]>
tested and implemented RagChatServiceIT.java
e0f73b1 
Signed-off-by: Siaa Gor <[email protected]>
added additional check before adding knowledge_base
c0a8b0e 
Signed-off-by: Siaa Gor <[email protected]>
updated Readme
42546ec 
Signed-off-by: Siaa Gor <[email protected]>
@SiaaG-dev SiaaG-dev changed the base branch from main to gkwan-ibm-rag August 10, 2025 03:08
GeeTransit and others added 3 commits August 12, 2025 09:51
@GeeTransit
Fix bug with some providers returning empty strings as tokens (#40)
2041d28 
With GitHub Models and gpt-4o-mini, the first token is sometimes an
empty string. The unit test breaks since the empty string denotes the
end of the message, thus checking if an empty string contains a year.
@AndrewSasmito @gkwan-ibm
Andrew update tests (#39)
c54d2fc 
* Fix packaging, toolchat.js, readme, pom

Signed-off-by: Andrew Sasmito <[email protected]>

* Add Google Gemini support, remove HF

Signed-off-by: Andrew Sasmito <[email protected]>

* Remove HF from the tests, add Gemini

Signed-off-by: Andrew Sasmito <[email protected]>

* Update readme

Signed-off-by: Andrew Sasmito <[email protected]>

* Remove gemini

Signed-off-by: Andrew Sasmito <[email protected]>

* Remove gemini from readme

Signed-off-by: Andrew Sasmito <[email protected]>

* Remove gemini from pom

Signed-off-by: Andrew Sasmito <[email protected]>

* Add ejb keyword

Signed-off-by: Andrew Sasmito <[email protected]>

* dev content review

Signed-off-by: Gilbert Kwan <[email protected]>

---------

Signed-off-by: Andrew Sasmito <[email protected]>
Signed-off-by: Gilbert Kwan <[email protected]>
Co-authored-by: Andrew Sasmito <[email protected]>
Co-authored-by: Gilbert Kwan <[email protected]>
@gkwan-ibm
Merge branch 'main' into sg-rag-mongodb-with-docker-6a
409699f
@gkwan-ibm gkwan-ibm added the experimental for experimental purpose label Aug 12, 2025
@gkwan-ibm
Copy link
Member

create a new branch from gkwan-ibm-rag to fix the following:

  • README remove HUGGING_FACE
  • README need instruction to stop mongodb container
  • retrieveAllEmbeddings() REST API is a dup of retrieve()
  • no need to have many txt files in the knowledge_base
    • only need to provide answers for the questions in README
  • instead of adding data at the onOpen of ChatService, should be done by a REST POST API
    • /embedding/init
    • no parameter
    • admin only
    • if data already in the db, response a message already initialized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

experimental for experimental purpose

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SiaaG-dev @gkwan-ibm @GeeTransit @AndrewSasmito