Recreate test for 30444 #30595

ajaypaul-ibm · 2025-01-21T09:40:20Z

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".
This PR tried to recreate the issue JPQL query for all entities in descending order returns no results on Oracle #30444 .

ajaypaul-ibm · 2025-01-21T11:09:35Z

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-01-21T11:16:37Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

3 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
Please describe in a separate comment how you tested your changes.

njr-11

Thanks for adding these tests. Please continue to work to get them closer to the scenario in #30444 that is failing on Oracle. If, after that, the error still does not reproduce, then work with Kyle on figuring out whether any differences in the Oracle version used might be the cause. If not that, then it will be necessary to look into whether preceding tests might contribute to the issue.

...pa_32_fat/test-applications/jakartadata/src/io/openliberty/jpa/data/tests/models/CityId.java

njr-11 · 2025-01-21T14:45:24Z

...plications/jakartadata/src/io/openliberty/jpa/data/tests/web/JakartaDataRecreateServlet.java

+    deleteAllEntities(City.class);
+    // Setup test data
+    City city1 = City.of("Prague", "Bohemia", 121878,Set.of(55901, 55902, 55903, 55904, 55906));
+    City city2 = City.of("Brno", "Moravia", 209352,Set.of(14601, 14602, 14603, 14604, 14606));
+    City city3 = City.of("Ostrava", "Silesia", 23456,Set.of(55906, 55907, 55908, 14604, 55902));
+
+    // Persist the cities
+    tx.begin();
+    em.persist(city1);
+    em.persist(city2);
+    em.persist(city3);
+    tx.commit();
+
+    // Execute the JPQL query
+    List<City> results;
+    tx.begin();
+    try {
+        results = em.createQuery("SELECT c FROM City c", City.class)
+                    .getResultList();
+        tx.commit();
+    } catch (Exception e) {
+        tx.rollback();
+        throw e;
+    }
+
+    // Verify the results
+    assertEquals(3, results.size());
+    assertTrue(results.stream().anyMatch(c -> c.getName().equals("Prague")));
+    assertTrue(results.stream().anyMatch(c -> c.getName().equals("Brno")));
+    assertTrue(results.stream().anyMatch(c -> c.getName().equals("Ostrava")));
+}


Looks fine, although a slightly different scenario and not properly indented

Suggested change

deleteAllEntities(City.class);

// Setup test data

City city1 = City.of("Prague", "Bohemia", 121878,Set.of(55901, 55902, 55903, 55904, 55906));

City city2 = City.of("Brno", "Moravia", 209352,Set.of(14601, 14602, 14603, 14604, 14606));

City city3 = City.of("Ostrava", "Silesia", 23456,Set.of(55906, 55907, 55908, 14604, 55902));

// Persist the cities

tx.begin();

em.persist(city1);

em.persist(city2);

em.persist(city3);

tx.commit();

// Execute the JPQL query

List<City> results;

tx.begin();

try {

results = em.createQuery("SELECT c FROM City c", City.class)

.getResultList();

tx.commit();

} catch (Exception e) {

tx.rollback();

throw e;

}

// Verify the results

assertEquals(3, results.size());

assertTrue(results.stream().anyMatch(c -> c.getName().equals("Prague")));

assertTrue(results.stream().anyMatch(c -> c.getName().equals("Brno")));

assertTrue(results.stream().anyMatch(c -> c.getName().equals("Ostrava")));

}

deleteAllEntities(City.class);

// Set up test data

City city1 = City.of("Prague", "Bohemia", 121878,Set.of(55901, 55902, 55903, 55904, 55906));

City city2 = City.of("Brno", "Moravia", 209352,Set.of(14601, 14602, 14603, 14604, 14606));

City city3 = City.of("Ostrava", "Silesia", 23456,Set.of(55906, 55907, 55908, 14604, 55902));

// Persist the cities

tx.begin();

em.persist(city1);

em.persist(city2);

em.persist(city3);

tx.commit();

// Execute the JPQL query

List<City> results;

tx.begin();

try {

results = em.createQuery("SELECT c FROM City c", City.class)

.getResultList();

tx.commit();

} catch (Exception e) {

tx.rollback();

throw e;

}

// Verify the results

assertEquals(3, results.size());

assertTrue(results.stream().anyMatch(c -> c.getName().equals("Prague")));

assertTrue(results.stream().anyMatch(c -> c.getName().equals("Brno")));

assertTrue(results.stream().anyMatch(c -> c.getName().equals("Ostrava")));

}

njr-11 · 2025-01-21T14:47:25Z

...plications/jakartadata/src/io/openliberty/jpa/data/tests/web/JakartaDataRecreateServlet.java

+    @Test
+    //Reference issue https://github.com/OpenLiberty/open-liberty/issues/30444
+    public void testSelectCity_30444() throws Exception {
+    deleteAllEntities(City.class);
+    // Setup test data
+    City city1 = City.of("Prague", "Bohemia", 1384732, Set.of(55901, 55902, 55903, 55904, 55906));
+    City city2 = City.of("Brno", "Moravia", 209352, Set.of(14601, 14602, 14603, 14604, 14606));
+    City city3 = City.of("Ostrava", "Silesia", 23456,Set.of(55906, 55907, 55908, 14604, 55902));
+
+    // Persist the cities
+    tx.begin();
+    em.persist(city1);
+    em.persist(city2);
+    em.persist(city3);
+    tx.commit();
+
+    // Execute the JPQL query
+    List<String> results;
+    tx.begin();
+    try {
+        results = em.createQuery("SELECT name FROM City WHERE name = :name ORDER BY population DESC", String.class)
+                    .setParameter("name", "Prague")
+                    .getResultList();
+        tx.commit();
+    } catch (Exception e) {
+        tx.rollback();
+        throw e;
+    }
+
+    // Verify the results
+    assertEquals(1, results.size());
+    assertEquals("Prague", results.get(0));
+}


Looks fine, although a slightly different scenario and not properly indented

Suggested change

@Test

//Reference issue https://github.com/OpenLiberty/open-liberty/issues/30444

public void testSelectCity_30444() throws Exception {

deleteAllEntities(City.class);

// Setup test data

City city1 = City.of("Prague", "Bohemia", 1384732, Set.of(55901, 55902, 55903, 55904, 55906));

City city2 = City.of("Brno", "Moravia", 209352, Set.of(14601, 14602, 14603, 14604, 14606));

City city3 = City.of("Ostrava", "Silesia", 23456,Set.of(55906, 55907, 55908, 14604, 55902));

// Persist the cities

tx.begin();

em.persist(city1);

em.persist(city2);

em.persist(city3);

tx.commit();

// Execute the JPQL query

List<String> results;

tx.begin();

try {

results = em.createQuery("SELECT name FROM City WHERE name = :name ORDER BY population DESC", String.class)

.setParameter("name", "Prague")

.getResultList();

tx.commit();

} catch (Exception e) {

tx.rollback();

throw e;

}

// Verify the results

assertEquals(1, results.size());

assertEquals("Prague", results.get(0));

}

@Test

//Reference issue https://github.com/OpenLiberty/open-liberty/issues/30444

public void testSelectCity_30444() throws Exception {

deleteAllEntities(City.class);

// Set up test data

City city1 = City.of("Prague", "Bohemia", 1384732, Set.of(55901, 55902, 55903, 55904, 55906));

City city2 = City.of("Brno", "Moravia", 209352, Set.of(14601, 14602, 14603, 14604, 14606));

City city3 = City.of("Ostrava", "Silesia", 23456,Set.of(55906, 55907, 55908, 14604, 55902));

// Persist the cities

tx.begin();

em.persist(city1);

em.persist(city2);

em.persist(city3);

tx.commit();

// Execute the JPQL query

List<String> results;

tx.begin();

try {

results = em.createQuery("SELECT name FROM City WHERE name = :name ORDER BY population DESC", String.class)

.setParameter("name", "Prague")

.getResultList();

tx.commit();

} catch (Exception e) {

tx.rollback();

throw e;

}

// Verify the results

assertEquals(1, results.size());

assertEquals("Prague", results.get(0));

}

njr-11 · 2025-01-21T14:52:02Z

...plications/jakartadata/src/io/openliberty/jpa/data/tests/web/JakartaDataRecreateServlet.java

+    @Test
+    //Reference issue https://github.com/OpenLiberty/open-liberty/issues/30444
+    public void testSelectKeys_30444() throws Exception {
+    deleteAllEntities(City.class);
+    // Setup test data
+    City city1 = City.of("Prague", "Bohemia", 1384732, Set.of(55901, 55902, 55903, 55904, 55906));
+    City city2 = City.of("Brno", "Moravia", 209352, Set.of(14601, 14602, 14603, 14604, 14606));
+    City city3 = City.of("Ostrava", "Silesia", 23456,Set.of(55906, 55907, 55908, 14604, 55902));
+
+    // Persist the cities
+    tx.begin();
+    em.persist(city1);
+    em.persist(city2);
+    em.persist(city3);
+    tx.commit();
+
+    // Execute the JPQL query
+    List<CityId> results;
+    tx.begin();
+    try {
+        results = em.createQuery(
+                        "SELECT new io.openliberty.jpa.data.tests.models.CityId(c.name, c.stateName) FROM City c WHERE c.stateName = :stateName ORDER BY c.population DESC",
+                        CityId.class)
+                    .setParameter("stateName", "Bohemia")
+                    .getResultList();
+        tx.commit();
+    } catch (Exception e) {
+        tx.rollback();
+        throw e;
+    }
+
+    // Verify the results
+    assertEquals(1, results.size());
+    assertEquals("Prague", results.get(0).getName());
+    assertEquals("Bohemia", results.get(0).getStateName());
+}


Looks fine, although a slightly different scenario and not properly indented. This one seems to be the closest to the failing Jakarta Data test, although still has some differences such as ordering on the population attribute rather than the name attribute which is a component of the IdClass.

Suggested change

@Test

//Reference issue https://github.com/OpenLiberty/open-liberty/issues/30444

public void testSelectKeys_30444() throws Exception {

deleteAllEntities(City.class);

// Setup test data

City city1 = City.of("Prague", "Bohemia", 1384732, Set.of(55901, 55902, 55903, 55904, 55906));

City city2 = City.of("Brno", "Moravia", 209352, Set.of(14601, 14602, 14603, 14604, 14606));

City city3 = City.of("Ostrava", "Silesia", 23456,Set.of(55906, 55907, 55908, 14604, 55902));

// Persist the cities

tx.begin();

em.persist(city1);

em.persist(city2);

em.persist(city3);

tx.commit();

// Execute the JPQL query

List<CityId> results;

tx.begin();

try {

results = em.createQuery(

"SELECT new io.openliberty.jpa.data.tests.models.CityId(c.name, c.stateName) FROM City c WHERE c.stateName = :stateName ORDER BY c.population DESC",

CityId.class)

.setParameter("stateName", "Bohemia")

.getResultList();

tx.commit();

} catch (Exception e) {

tx.rollback();

throw e;

}

// Verify the results

assertEquals(1, results.size());

assertEquals("Prague", results.get(0).getName());

assertEquals("Bohemia", results.get(0).getStateName());

}

@Test

//Reference issue https://github.com/OpenLiberty/open-liberty/issues/30444

public void testSelectKeys_30444() throws Exception {

deleteAllEntities(City.class);

// Set up test data

City city1 = City.of("Prague", "Bohemia", 1384732, Set.of(55901, 55902, 55903, 55904, 55906));

City city2 = City.of("Brno", "Moravia", 209352, Set.of(14601, 14602, 14603, 14604, 14606));

City city3 = City.of("Ostrava", "Silesia", 23456,Set.of(55906, 55907, 55908, 14604, 55902));

// Persist the cities

tx.begin();

em.persist(city1);

em.persist(city2);

em.persist(city3);

tx.commit();

// Execute the JPQL query

List<CityId> results;

tx.begin();

try {

results = em.createQuery(

"SELECT new io.openliberty.jpa.data.tests.models.CityId(c.name, c.stateName) FROM City c WHERE c.stateName = :stateName ORDER BY c.population DESC",

CityId.class)

.setParameter("stateName", "Bohemia")

.getResultList();

tx.commit();

} catch (Exception e) {

tx.rollback();

throw e;

}

// Verify the results

assertEquals(1, results.size());

assertEquals("Prague", results.get(0).getName());

assertEquals("Bohemia", results.get(0).getStateName());

}

Recreate test for 30444

a82ab4d

ajaypaul-ibm requested a review from njr-11 January 21, 2025 09:40

LibbyBot added the noproductcode label Jan 21, 2025

njr-11 reviewed Jan 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recreate test for 30444 #30595

Recreate test for 30444 #30595

ajaypaul-ibm commented Jan 21, 2025

ajaypaul-ibm commented Jan 21, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Jan 21, 2025

njr-11 left a comment

njr-11 Jan 21, 2025

njr-11 Jan 21, 2025

njr-11 Jan 21, 2025

Recreate test for 30444 #30595

Are you sure you want to change the base?

Recreate test for 30444 #30595

Conversation

ajaypaul-ibm commented Jan 21, 2025

ajaypaul-ibm commented Jan 21, 2025 • edited by LibbyBot Loading

LibbyBot commented Jan 21, 2025

Code analysis and actions

njr-11 left a comment

Choose a reason for hiding this comment

njr-11 Jan 21, 2025

Choose a reason for hiding this comment

njr-11 Jan 21, 2025

Choose a reason for hiding this comment

njr-11 Jan 21, 2025

Choose a reason for hiding this comment

ajaypaul-ibm commented Jan 21, 2025 •

edited by LibbyBot

Loading