OLMIS-8206: Reject concurrent requisition approval#127
Merged
Conversation
Adds a server-side lock so two approvals of the same requisition cannot both run and create duplicate stock events.
michaldev0
force-pushed
the
OLMIS-8206-reject-concurrent-approval
branch
from
ef87b4f to
78bde93
Compare
lwojewnik
approved these changes
Jun 2, 2026
lwojewnik
left a comment
lwojewnik
left a comment
Contributor
There was a problem hiding this comment.
LGTM. One note about the new Redis lock. If a requisition approval ever takes longer than the 30-minute lock timeout, another user could start approving the same requisition before the first approval finishes.
This is very unlikely, but it could result in duplicate or incorrect data being created.
The lock is renewed while an approval runs and released only by the approval that took it.
|
Drops the holder class and uses constructor injection; lock behavior is unchanged.
TransactionSynchronization is not a functional interface in Spring 5.2, so it cannot be a lambda.
lwojewnik
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a server-side lock so two approvals of the same requisition cannot both run and create duplicate stock events.
This change is