OLMIS-7779: Add supplyingFacility query parameter to /api/requisitions/search#125
Merged
Merged
Conversation
michaldev0
force-pushed
the
OLMIS-7779-supplying-facility-search-param
branch
2 times, most recently
from
1fa8748 to
9efc737
Compare
…s/search External integrations (MSupply) can now filter requisitions by supplyingFacility server-side instead of pulling all and filtering client-side.
michaldev0
force-pushed
the
OLMIS-7779-supplying-facility-search-param
branch
from
9efc737 to
24ab6d8
Compare
mgrochalskisoldevelo
requested changes
May 26, 2026
mgrochalskisoldevelo
left a comment
mgrochalskisoldevelo
left a comment
Contributor
There was a problem hiding this comment.
Please add an integration test for the supplyingFacility filter in the RequisitionRepositoryIntegrationTest. Every other filter has one. The test could save two requisitions with different supplyingFacilityId values, then search using withSupplyingFacility(...) and assert that only the matching one is returned.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External integrations (MSupply) can now filter requisitions by supplyingFacility server-side instead of pulling all and filtering client-side.
This change is