This repository was archived by the owner on May 15, 2026. It is now read-only.
Clamp view_range end to file length and emit warning instead of error (fixes #154)#157
Merged
Conversation
…error when beyond EOF (fixes #154) - Normalize end_line by capping to num_lines and allow -1 as before - Append NOTE: warning to output when clamped - Update tests to assert on warning text Co-authored-by: openhands <openhands@all-hands.dev>
ryanhoangt
reviewed
Aug 19, 2025
Co-authored-by: openhands <openhands@all-hands.dev>
ryanhoangt
reviewed
Aug 21, 2025
ryanhoangt
reviewed
Aug 21, 2025
ryanhoangt
reviewed
Aug 21, 2025
ryanhoangt
approved these changes
Aug 21, 2025
enyst
pushed a commit
to enyst/openhands-aci
that referenced
this pull request
Aug 22, 2025
…fixes OpenHands#154) (OpenHands#157) * editor: clamp view_range end to file length, emit warning instead of error when beyond EOF (fixes OpenHands#154) - Normalize end_line by capping to num_lines and allow -1 as before - Append NOTE: warning to output when clamped - Update tests to assert on warning text Co-authored-by: openhands <openhands@all-hands.dev> * Prepend warning message instead of appending it Co-authored-by: openhands <openhands@all-hands.dev> * Update openhands_aci/editor/editor.py * Update openhands_aci/editor/editor.py * bump to 0.3.2 * Update tests/integration/editor/test_error_handling.py --------- Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Ryan H. Tran <descience.thh10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Fixes #154: Previously, requesting a range beyond EOF raised an error. The desired behavior is to show up to the end of the file and warn the user.
Changes
Testing
Notes
Co-authored-by: openhands openhands@all-hands.dev
@xingyaoww can click here to continue refining the PR