This repository was archived by the owner on May 15, 2026. It is now read-only.
GeminiEditor: replace with expected_replacements and EOL handling (Phase 1a)#155
Closed
enyst wants to merge 8 commits into
Closed
GeminiEditor: replace with expected_replacements and EOL handling (Phase 1a)#155enyst wants to merge 8 commits into
enyst wants to merge 8 commits into
Conversation
…__init__; add unit tests Co-authored-by: OpenHands-GPT-5 openhands@all-hands.dev
enyst
changed the title
enyst
changed the title
enyst
changed the title
…CLIResult.error on parameter issues\n\nMatches unit test expectations in tests/unit/editor/test_gemini_editor.py.\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…nds <openhands@all-hands.dev>
Helps reduce the amount of retries when using an LLM like Devstral.
…fixes OpenHands#154) (OpenHands#157) * editor: clamp view_range end to file length, emit warning instead of error when beyond EOF (fixes OpenHands#154) - Normalize end_line by capping to num_lines and allow -1 as before - Append NOTE: warning to output when clamped - Update tests to assert on warning text Co-authored-by: openhands <openhands@all-hands.dev> * Prepend warning message instead of appending it Co-authored-by: openhands <openhands@all-hands.dev> * Update openhands_aci/editor/editor.py * Update openhands_aci/editor/editor.py * bump to 0.3.2 * Update tests/integration/editor/test_error_handling.py --------- Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Ryan H. Tran <descience.thh10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Semantics
Why
Companion PR
Co-authored-by: openhands openhands@all-hands.dev