fix: skip redundant ready Cloud onboarding#1942
Draft
neubig wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks
Contributor
✅ Mock-LLM E2E Tests8/8 passed Commit: Details
Posted by the Mock-LLM E2E workflow · results are deterministic (scripted LLM responses) |
Contributor
✅ Mock-LLM Docker E2E Test Results60/60 passed Commit: Details
Posted by the Mock-LLM E2E workflow · results are deterministic (scripted LLM responses) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENT:
Why
#1928 adds build-time and runtime deployment flags to suppress onboarding for pre-provisioned SaaS users. The active locked Cloud backend already exposes whether it has a usable LLM, so Canvas can make this decision from runtime capability instead of adding another deployment setting.
This keeps the browser-local onboarding marker authoritative for normal installs while avoiding a redundant wizard when the locked Cloud deployment has already provided everything the wizard would collect.
Summary
openhands-onboardedcompletion marker.User impact
Pre-provisioned OpenHands Cloud users land directly on the ready home screen without requiring
VITE_DISABLE_ONBOARDINGorAGENT_CANVAS_DISABLE_ONBOARDING. Local and custom deployment first-run behavior is unchanged.Related
Validation
npm run lintnpm test -- --run __tests__/root.test.tsx __tests__/components/onboarding/onboarding-host.test.tsx— 30 passednpm run buildTDD evidence
The two ready locked-Cloud expectations were added first and failed against
mainbecause settings were never queried and the modal remained mounted. They pass with the scoped readiness gate.Type
🐳 Docker images for this PR
• GHCR package: https://github.com/OpenHands/agent-canvas/pkgs/container/agent-canvas
ghcr.io/openhands/agent-canvasghcr.io/openhands/agent-server:1.37.0-pythonopenhands-automation==1.3.1d18bd6cb4ca5be352a05c896fbc2bc713e0b7a73Pull (multi-arch manifest)
# Multi-arch manifest — Docker automatically pulls the correct architecture docker pull ghcr.io/openhands/agent-canvas:sha-d18bd6cRun
All tags pushed for this build
About Multi-Architecture Support
sha-d18bd6c) is a multi-arch manifest supporting both amd64 and arm64sha-d18bd6c-amd64) are also available if needed