forked from goncalossilva/acts_as_paranoid
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opengov branch #4
Open
jpterry
wants to merge
115
commits into
master
Choose a base branch
from
opengov-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can announce maintenance policy in README.
activerecord on travis.
Fix trailing spaces on files.
Now it looks like what a gem generated with `bundle gem` would look like. Also: - Change requirements back to ActiveRecord 3.1, seen as the gem is not ready for prime time with Rails 4; - Silence tests; - Indicate which license this gem has.
Modernized the gem, and a few other tweaks.
- Add build status badge - Mention that the gem also works for Rails 3.1
Testing with AR 3.1 and 3.2
Add Zachary to the authors and change the gem homepage.
between patch level releases.
Conflicts: lib/acts_as_paranoid/core.rb
… delete to paranoid associations" see: 51cc825
…back returns false" see: cb800f2
…r the main model first and then its dependents" see: 60c236e?diff=split
Soft Delete callback
Adding scoping to dependent relationships
…code. Updated specs and builds to work better.
Added without_default_scope option
* Update readme.md foreign_key => :parent_id TO :foreign_key => :parent_id * When recovering associated records, need to specify the table name when querying the recovery window. Otherwise, an 'ambiguous column' error is thrown * Thanks @mvz <3 * Execute tests on Ruby 2.2 as well * Update rails 4.2 to latest release for CI * Remove edge tests since Rails 5 is unsupported at this time * Bump version * ActiveRecord queries with includes now respect :with_deleted => true * Update core.rb Is better to use alias method instead of defining delegator methods. * Remove legacy observer reference * Add test for decrement counters * Manually decrement counters with activerecord >= 4.2 * Compatibility with Rails 5 * Running tests for Rails 5 with compatible versions of ruby * Fix typo * fix Default scope * Get working bundler before running tests Also add Ruby 2.3 and Jruby 9k to matrix * Add patch-levels to rvm rubies for travis CI * Added support for allow_nulls option for boolean column. * ✂️ * Clarify supported versions of Rails * Thank you @sjke for working on Rails 5 support * Some doc cleanups 💅 * Revert "Merge pull request goncalossilva#40 from paveldruzyak/master" This reverts commit 8df82c4, reversing changes made to 64bfe2f. * Document destroy_fully! Closes goncalossilva#51 See also 3c12279 * 💅 * Bump to first release candidate Co-authored-by: Jenya Zueva <[email protected]> Co-authored-by: Cosmin A <[email protected]> Co-authored-by: Zachary Scott <[email protected]> Co-authored-by: Zachary Scott <[email protected]> Co-authored-by: Teemu Kupari <[email protected]> Co-authored-by: Ehsan Yousefi <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: Pavel Druziak <[email protected]> Co-authored-by: Andrey Ponomarenko <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Nu-hin <[email protected]>
* Update readme.md foreign_key => :parent_id TO :foreign_key => :parent_id * When recovering associated records, need to specify the table name when querying the recovery window. Otherwise, an 'ambiguous column' error is thrown * Thanks @mvz <3 * Execute tests on Ruby 2.2 as well * Update rails 4.2 to latest release for CI * Remove edge tests since Rails 5 is unsupported at this time * Bump version * ActiveRecord queries with includes now respect :with_deleted => true * Update core.rb Is better to use alias method instead of defining delegator methods. * Remove legacy observer reference * Add test for decrement counters * Manually decrement counters with activerecord >= 4.2 * Compatibility with Rails 5 * Running tests for Rails 5 with compatible versions of ruby * Fix typo * fix Default scope * Get working bundler before running tests Also add Ruby 2.3 and Jruby 9k to matrix * Add patch-levels to rvm rubies for travis CI * Added support for allow_nulls option for boolean column. * ✂️ * Clarify supported versions of Rails * Thank you @sjke for working on Rails 5 support * Some doc cleanups 💅 * Revert "Merge pull request goncalossilva#40 from paveldruzyak/master" This reverts commit 8df82c4, reversing changes made to 64bfe2f. * Document destroy_fully! Closes goncalossilva#51 See also 3c12279 * 💅 * Bump to first release candidate * Bump to final * `active_record v5.1` support * Remove type_cast_for_schema call and pass relation to exists? Co-authored-by: Jenya Zueva <[email protected]> Co-authored-by: Cosmin A <[email protected]> Co-authored-by: Zachary Scott <[email protected]> Co-authored-by: Zachary Scott <[email protected]> Co-authored-by: Teemu Kupari <[email protected]> Co-authored-by: Ehsan Yousefi <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: Pavel Druziak <[email protected]> Co-authored-by: Andrey Ponomarenko <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Nu-hin <[email protected]> Co-authored-by: itsmechlark <[email protected]> Co-authored-by: Shane Cavanaugh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge! Just meant to point out the differences.