Skip to content

[Bug] Handle empty output from fastp #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bug] Handle empty output from fastp #482

wants to merge 1 commit into from

Conversation

rzlim08
Copy link

@rzlim08 rzlim08 commented Apr 26, 2023

  • If fastp filters out all reads the output file does not have any bases. This leads to a division by zero error which causes a segfault in the HTML generation code

KimBioInfoStudio
KimBioInfoStudio approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@KimBioInfoStudio KimBioInfoStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzlim08
Copy link
Author

rzlim08 commented Jun 23, 2023

LGTM

Thanks!

@sfchen would it be possible to get a review and merge if all looks ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@KimBioInfoStudio KimBioInfoStudio KimBioInfoStudio approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzlim08 @KimBioInfoStudio