-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note on charge generation during CLI workflows #1117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 93.51% 91.87% -1.65%
==========================================
Files 142 142
Lines 10608 10608
==========================================
- Hits 9920 9746 -174
- Misses 688 862 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two typos, then lgtm!
No API break detected ✅ |
This PR adds a note to inform users of the CLI that we are now generating charges when planning networks. I have also added a link to the new tutorial in example notebooks which should be merged first OpenFreeEnergy/ExampleNotebooks#187
Checklist
news
entryDevelopers certificate of origin