Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Test a self self transformation with different charges #1116

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Feb 5, 2025

Benzene->Toluene has the right partial charges in the core region
Benzene->Benzene does not

Checklist

  • Added a news entry

Developers certificate of origin

Copy link

github-actions bot commented Feb 5, 2025

No API break detected ✅

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.86%. Comparing base (eef438f) to head (0efb505).

Files with missing lines Patch % Lines
openfe/protocols/openmm_rfe/equil_rfe_methods.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
- Coverage   93.51%   91.86%   -1.66%     
==========================================
  Files         142      142              
  Lines       10608    10617       +9     
==========================================
- Hits         9920     9753     -167     
- Misses        688      864     +176     
Flag Coverage Δ
fast-tests 91.86% <93.75%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant