Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix v0.16.3 #1490

Closed
wants to merge 6 commits into from
Closed

Hotfix v0.16.3 #1490

wants to merge 6 commits into from

Conversation

adelmemariani
Copy link
Contributor

@adelmemariani adelmemariani commented Dec 6, 2023

Summary of the discussion

Describe the findings of the discussion in the issue or meeting.

Type of change (CHANGELOG.md)

Added

Updated

Removed

  • remove prints inside view.py in the factsheet app

Workflow checklist

Automation

Closes #1488
Closes #1489
Closes #1487

Part of #1478

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@adelmemariani adelmemariani requested a review from jh-RLI December 6, 2023 12:51
@jh-RLI
Copy link
Contributor

jh-RLI commented Dec 6, 2023

Hey @adelmemariani I have to be annoying about the branch again. This is not a HotFix as it doesn't merge directly into the master branch and also introduces new features.

I think you wanted to use the HotFix branch because you think it's easier for you because you only have to create one branch :D If that's the case and you're having trouble creating multiple branches, then you can also create a normal feature branch and reference any issues you implement. HotFix branches only serve a specific use case.

If it's not too much trouble, please rename the branch and create a new PR :) Thank you!

i suggest a branch name like feature-1488-1489-1487-enhance-scenario-bundle-functionality.
(not sure if this fixes #1478 also if it is you can include it in the list)

@jh-RLI
Copy link
Contributor

jh-RLI commented Dec 6, 2023

You can use Git to rename the branch, but GitHub will require you to create a new PullRequest because it can't recognize what the previous branch name was.

@adelmemariani
Copy link
Contributor Author

Hey @adelmemariani I have to be annoying about the branch again. This is not a HotFix as it doesn't merge directly into the master branch and also introduces new features.

I think you wanted to use the HotFix branch because you think it's easier for you because you only have to create one branch :D If that's the case and you're having trouble creating multiple branches, then you can also create a normal feature branch and reference any issues you implement. HotFix branches only serve a specific use case.

If it's not too much trouble, please rename the branch and create a new PR :) Thank you!

i suggest a branch name like feature-1488-1489-1487-enhance-scenario-bundle-functionality. (not sure if this fixes #1478 also if it is you can include it in the list)

Thanks @jh-RLI . I got it. Please see this PR

@jh-RLI
Copy link
Contributor

jh-RLI commented Dec 6, 2023

Thanks alot @adelmemariani. I will close this PR

@jh-RLI jh-RLI closed this Dec 6, 2023
@jh-RLI jh-RLI deleted the hotfix-v0.16.3 branch January 30, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants