Custom rate and named standard rate for units (Issue #1216) #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idation for integers in custom value
… to hour on dropdown
…anslation for unit.sec.in.rate.enter
…t value to custom input if nonstandard value
- Update unit edit logic for useEffect more - Change custom sec in rate to require enter - Disable save if not changed and incomplete custom input - use setState and not directy set state - consistently use === & !== - Added SHL comments for original developers to look at and then remove - Formatting - Minor edit Note create unit does not have new logic and bar may need to be update to be similar
Note that @gyordong worked with me on these changes. - Also has comments with ?? on items to do. - Not carefully tested/completed.
…ts on customratevalid(), included customratevalid in editunit's canSave useEffect check to fix a bug with negative numbers.
huss
changed the title
|
@gyordong I started to review this PR and found changes that don't seem related to the work done. I looked into this and found that previously merged changes seem to be gone in several files. One example is processData.js (line 787-8). Did you have merge conflicts when you brought in development? I see a commit with the msg "fixing mrge" on 11/15/24 but did not easily determine that is where the change happened. The bottom line is I'm nervous about these changes and what may now be out of sync with development. I think this needs to be resolved carefully (and let me know if you think I am wrong about this). If we should discuss more then please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a custom rate box for unit creation and edit.
Fixes #1216
Type of change
Checklist
Limitations