[EDGE] Add tests and update Victron components#3505
Open
Sn0w3y wants to merge 3 commits intoOpenEMS:developfrom
Open
[EDGE] Add tests and update Victron components#3505Sn0w3y wants to merge 3 commits intoOpenEMS:developfrom
Sn0w3y wants to merge 3 commits intoOpenEMS:developfrom
Conversation
This commit introduces several changes across the Victron components and their tests. Specifically, it adds new test configurations and test cases for Victron battery inverter, AC in/out meters, and PV inverter via DC charger components. Additionally, it updates the VictronBatteryInverterImpl and VictronEssImpl classes to improve event handling and reference policy configurations.
Collaborator
Author
|
@GrisuBerlin and @DerWahreKlinki could you check if everything still works? |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #3505 +/- ##
==============================================
- Coverage 59.58% 29.17% -30.40%
==============================================
Files 3006 291 -2715
Lines 130472 8147 -122325
Branches 9639 1397 -8242
==============================================
- Hits 77723 2376 -75347
+ Misses 49845 5648 -44197
+ Partials 2904 123 -2781 🚀 New features to boost your workflow:
|
Removed unnecessary ESS and battery references from Victron components to simplify the codebase and improve maintainability. This change affects Victron battery, battery inverter, and ESS configurations and implementations by eliminating redundant or unused configuration parameters and references.
This commit updates the ChargeStateEss enumeration by correcting the value of BULK_STOPPED from 1 to 8, ensuring the enum values are unique and correctly ordered. Additionally, it significantly extends the VictronEssImplTest with new test cases and setup for comprehensive testing of the Victron Energy Storage System (ESS) implementation.
Collaborator
|
BatteryInverter never gets a reference to battery so (battery-)limits cannot be calculated. Maybe you/we should transfer hardware checks to the Ess component? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces several changes across the Victron components and their tests. Specifically, it adds new test configurations and test cases for Victron battery inverter, AC in/out meters, and PV inverter via DC charger components. Additionally, it updates the VictronBatteryInverterImpl and VictronEssImpl classes to improve event handling and reference policy configurations.
See: #3457 (comment)
and: #3457