Added GoodWe Charger PV 4 to 8 and changed/added calculation of power#3444
Added GoodWe Charger PV 4 to 8 and changed/added calculation of power#3444Bockhorn-IT wants to merge 5 commits intoOpenEMS:developfrom
Conversation
instead of reading the power from register. For PV strings greater than number 4 there are no registers for the power, only for current and voltage, so we calculate them all instead.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (62.40%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3444 +/- ##
=============================================
+ Coverage 59.62% 59.64% +0.02%
Complexity 112 112
=============================================
Files 2894 2899 +5
Lines 124658 124769 +111
Branches 9343 9355 +12
=============================================
+ Hits 74318 74405 +87
+ Misses 47522 47519 -3
- Partials 2818 2845 +27 🚀 New features to boost your workflow:
|
| new ComponentTest(new GoodWeChargerPv2()) // | ||
| .addReference("cm", new DummyConfigurationAdmin()) // | ||
| .addReference("setModbus", new DummyModbusBridge("modbus0")) // | ||
| .activate(MyConfig.create() // |
There was a problem hiding this comment.
Please keep the Format as before.
| new ComponentTest(new GoodWeChargerPv1()) // | ||
| .addReference("cm", new DummyConfigurationAdmin()) // | ||
| .addReference("setModbus", new DummyModbusBridge("modbus0")) // | ||
| .activate(MyConfig.create() // |
There was a problem hiding this comment.
Please keep the Format as before.
| public void test() throws Exception { | ||
| new ComponentTest(new GoodWeChargerPv3()) // | ||
| .addReference("cm", new DummyConfigurationAdmin()) // | ||
| .addReference("setModbus", new DummyModbusBridge("modbus0")).activate(MyConfig.create() // |
There was a problem hiding this comment.
thx, mistakly formatted the file
Sn0w3y
left a comment
Sn0w3y
left a comment
There was a problem hiding this comment.
The Tests are Failing right now aswell.
and forgot one file to commit, sorry |
|
Hi @Bockhorn-IT, Initially, we had nearly the same implementation, but our problem was that the GoodWe had inaccurate current values for each string. While measuring, a lot of test systems, we had total different current values even if the Nr. of Modules and the cardinal direction was the same, especially with low power. |
This PR has been automatically marked as stale due to inactivityIf it is still relevant, please update the PR. Before updating, please review our Contribution Guidelines to ensure all required information is provided. |
3 participants
Added GoodWe Charger PV 4 to 8 and changed/added calculation of power instead of reading the power from register.
For PV strings greater than number 4 there are no registers for the power, only for current and voltage, so we calculate them all instead.