Refactor common code #2226
Open
Refactor common code #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruzihm
commented
Feb 23, 2025
|
|
||
| /// <summary> | ||
| /// Custom attribute for declaring <see cref="OpcodeMetadata"/> metadata for individual opcodes | ||
| /// </summary> | ||
| [AttributeUsage(AttributeTargets.Field)] | ||
| internal sealed class OpcodeMetadataAttribute : Attribute { | ||
| public sealed class OpcodeMetadataAttribute : Attribute { |
There was a problem hiding this comment.
This change was to allow referencing OpcodeMetadataAttribute into this common assembly class from the compiler assembly. Let me know if there's a better approach.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
worried for a sec 😅 but it looks like goon broke the compilation 🫢 |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts code common among server, client, compiler into an OpenDreamCommon assembly
Puts code common among only server and compiler into a NoClient assembly (currently just for the MD5 call)
Removes compiler from server (#1490)
Deduplicates DreamValueType and DMValueType into just DMValueType. (these were different for some reason)