Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely ignore/don't require closing tags of void elements #2225

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Ruzihm
Copy link
Contributor

@Ruzihm Ruzihm commented Feb 21, 2025

HTML parser should not push void elements (or tags marked as self-closing in the style of xhtml) into the tag stack.
HTML parser should just ignore attempted closing tags of void elements instead of peeking into the tag stack. Might be good to throw a warning when it is encountered (although, the DM reference documents a mysterious <img></img>, so I don't know)

This is a continuation on !2217 which did not fix the problem adequately (Or, honestly, at all. Whoops!)

#2187.

@boring-cyborg boring-cyborg bot added the Client Involves the OpenDream client label Feb 21, 2025
@wixoaGit wixoaGit merged commit 30a332d into OpenDreamProject:master Feb 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Involves the OpenDream client size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants