Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 516 values_ procs #2213

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Feb 11, 2025

@boring-cyborg boring-cyborg bot added Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime labels Feb 11, 2025
@github-actions github-actions bot added size/L and removed size/M labels Feb 11, 2025
@ike709 ike709 changed the title Implement some 516 values_ procs Implement 516 values_ procs Feb 11, 2025
@amylizzle amylizzle mentioned this pull request Feb 10, 2025
25 tasks
Comment on lines +3158 to +3160
// We need to copy the list so we can modify while enumerating
var listCopy = new List<DreamValue>(values);
foreach (var val in listCopy) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be possible to make this a for(...; ...; ...) loop instead. That could end up depending on list.RemoveValue()'s behavior though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants