Implement 516 behavior for ~= and ~!
#2212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wixoaGit
requested changes
Feb 15, 2025
| @@ -372,6 +372,8 @@ public override DreamValue OperatorEquivalent(DreamValue b) { | |||
| return DreamValue.False; | |||
| if (GetLength() != secondList.GetLength()) | |||
| return DreamValue.False; | |||
| if(IsAssociative && (!secondList.IsAssociative || secondList.GetAssociativeValues().Count != GetAssociativeValues().Count)) | |||
There was a problem hiding this comment.
list(a=null) ~= list("a") is TRUE so returning early if IsAssociative != secondList.IsAssociative is incorrect. At least as long as IsAssociative can still treat all-null associative values as associative.
| if (IsAssociative) { | ||
| var secondListAssoc = secondList.GetAssociativeValues(); | ||
| foreach (var kvp in GetAssociativeValues()) { | ||
| if(!secondListAssoc.TryGetValue(kvp.Key, out var assocValue) || !assocValue.Equals(kvp.Value)) |
There was a problem hiding this comment.
The lack of a value in either assoc lists should be treated as null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2203