Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typemaker 1.1 rebased - fixes and improvements #2208

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Readd crash to jointext with invalid argument type

201b1ec
Select commit
Loading
Failed to load commit list.
Open

Typemaker 1.1 rebased - fixes and improvements #2208

Readd crash to jointext with invalid argument type
201b1ec
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / InspectCode succeeded Feb 23, 2025 in 4s

81 new alerts

New alerts in code changed by this pull request

  • 68 warnings
  • 13 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 1273 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Parameter 'procParameters' hides outer parameter with the same name Warning

Parameter 'procParameters' hides outer parameter with the same name

Check warning on line 2754 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 2775 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 2809 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 2825 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 2858 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 2868 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 2880 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 2893 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 2895 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 2918 in DMCompiler/Compiler/DM/DMParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 20 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 25 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Inconsistent Naming Warning

Name 'CurrentReturnType' does not match rule 'Instance fields (private)'. Suggested name is '_currentReturnType'.

Check warning on line 60 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 75 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check notice on line 79 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Merge null/pattern checks into complex pattern Note

Merge into pattern

Check notice on line 79 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Merge null/pattern checks into complex pattern Note

Merge into pattern

Check warning on line 172 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Parameter 'currentReturnType' has no matching param tag in the XML comment for DMCompiler.DM.Builders.DMProcBuilder.HandleCallableSelfLeft (but other parameters do) Warning

Parameter 'currentReturnType' has no matching param tag in the XML comment for DMCompiler.DM.Builders.DMProcBuilder.HandleCallableSelfLeft (but other parameters do)

Check warning on line 172 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Parameter 'realExpr' has no matching param tag in the XML comment for DMCompiler.DM.Builders.DMProcBuilder.HandleCallableSelfLeft (but other parameters do) Warning

Parameter 'realExpr' has no matching param tag in the XML comment for DMCompiler.DM.Builders.DMProcBuilder.HandleCallableSelfLeft (but other parameters do)

Check warning on line 172 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Parameter 'isTemporary' has no matching param tag in the XML comment for DMCompiler.DM.Builders.DMProcBuilder.HandleCallableSelfLeft (but other parameters do) Warning

Parameter 'isTemporary' has no matching param tag in the XML comment for DMCompiler.DM.Builders.DMProcBuilder.HandleCallableSelfLeft (but other parameters do)

Check warning on line 172 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Parameter 'checkConditions' has no matching param tag in the XML comment for DMCompiler.DM.Builders.DMProcBuilder.HandleCallableSelfLeft (but other parameters do) Warning

Parameter 'checkConditions' has no matching param tag in the XML comment for DMCompiler.DM.Builders.DMProcBuilder.HandleCallableSelfLeft (but other parameters do)

Check notice on line 176 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Type pattern and casts can be merged Note

Merge cast with type pattern

Check warning on line 190 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 193 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check notice on line 199 in DMCompiler/DM/Builders/DMProcBuilder.cs

See this annotation in the file changed.

Code scanning / InspectCode

Type pattern and casts can be merged Note

Merge cast with type pattern