Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Division unit test fixes #2150

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Division unit test fixes #2150

merged 3 commits into from
Dec 30, 2024

Conversation

ike709
Copy link
Collaborator

@ike709 ike709 commented Dec 29, 2024

  • Added error codes to // COMPILE ERROR division tests that didn't have them
  • Fixed // RUNTIME ERROR unit tests not passing if the runtime error occurred prior to RunTest() execution. _dreamMan.LastDMException is now reset prior to running the current test, and the test now checks if it's null.
  • Moved the now-passing divide-by-zero tests to the Tests directory

@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Dec 29, 2024
@ike709 ike709 requested a review from wixoaGit December 30, 2024 00:04
@wixoaGit wixoaGit merged commit aab2f49 into OpenDreamProject:master Dec 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
Compiler Involves the OpenDream compiler size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ike709 @wixoaGit