Skip to content

Tracy #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Tracy #2127

wants to merge 41 commits into from

Conversation

amylizzle
Copy link
Collaborator

@amylizzle amylizzle commented Dec 7, 2024

with thanks to https://github.com/wixoaGit/OpenDreamFork/tree/tracy for doing most of the work

When in TOOLS build activates proc logging for DM with source locations.

image
image
also it does native procs so we can use it to make OD faster
image
Memory tracing:
image
image

Note: DreamObject memory footprint is not accurate. It assumes that each object allocates its total possible memory.

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Dec 7, 2024
@github-actions github-actions bot added the size/L label Dec 7, 2024
@boring-cyborg boring-cyborg bot added the Client Involves the OpenDream client label Dec 8, 2024
[CVarDefs]
public abstract class OpenDreamCVars {
public static readonly CVarDef<string> JsonPath =
CVarDef.Create("opendream.json_path", String.Empty, CVar.SERVERONLY);

Check notice

Code scanning / InspectCode

Replace built-in type reference with a CLR type name or a keyword in static member access expressions Note

Built-in type reference is inconsistent with code style settings
@amylizzle amylizzle marked this pull request as ready for review December 8, 2024 16:58
@github-actions github-actions bot added size/XL and removed size/L labels Dec 9, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

private static readonly Dictionary<string, CString> PlotNameCache = new();

private static bool _isActivated;
/// <summary>

Check warning

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0
}


public sealed class ActivateProfilerCommand : IConsoleCommand {

Check warning

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 1 instead of 2
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Apr 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

}

return _resourceData;
return _resourceDataBacking;

Check warning

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0
return _resourceData;
return _resourceDataBacking;
}
private set {

Check notice

Code scanning / InspectCode

Property can be made init-only: Private accessibility Note

Property can be made init-only
Copy link

github-actions bot commented May 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Involves the OpenDream client Runtime Involves the OpenDream server/runtime size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants