COMPILE ERROR unit tests now require a specific error code
#2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wixoaGit
requested changes
Oct 3, 2024
Co-authored-by: wixoa <[email protected]>
Co-authored-by: wixoa <[email protected]>
wixoaGit
requested changes
Oct 3, 2024
wixoaGit
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests that check for a compiler error must now specify the error code that they want.
Example:
// COMPILE ERROR OD0404For the tests that do not explicitly elevate a pragma, I got the error code by running the test in the OD compiler bot (while renaming
RunTest()tomain()) and seeing what got emitted. This means that if any test is wildly broken currently, this PR doesn't really fix that.I recommend reviewing it by commit, they're split up pretty nicely.