ADOPTED: Datum softdels #1920
Merged
ADOPTED: Datum softdels #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: wixoa <[email protected]>
Co-authored-by: wixoa <[email protected]>
Co-authored-by: wixoa <[email protected]>
Co-authored-by: wixoa <[email protected]>
Co-authored-by: wixoa <[email protected]>
Co-authored-by: wixoa <[email protected]>
Co-authored-by: wixoa <[email protected]>
boring-cyborg
bot
added
Compiler
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Running goon with only softdels (ie, the whole |
| public sealed class WeakDreamRef { | ||
| private readonly WeakReference<DreamObject> _weakReference; | ||
|
|
||
| public WeakDreamRef(DreamObject obj) => _weakReference = new WeakReference<DreamObject>(obj); |
Check notice
Code scanning / InspectCode
Convert constructor into primary constructor Note
wixoaGit
requested changes
Oct 4, 2024
wixoaGit
requested changes
Oct 4, 2024
Co-authored-by: wixoa <[email protected]>
wixoaGit
requested changes
Oct 4, 2024
wixoaGit
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted from #1776
Seems to have dropped 2Gb from the memory usage of goon on cog2.
Draft because some mildly weird stuff needs investigating first