Peephole optimize proc returns #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
Compiler
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| input.RemoveRange(index, 2); | ||
| input.Insert(index, | ||
| new AnnotatedBytecodeInstruction(DreamProcOpcode.ReturnReferenceValue, | ||
| new List<IAnnotatedBytecode> { pushVal })); |
Check warning
Code scanning / InspectCode
Possible null reference argument for a parameter. Warning
| input.RemoveRange(index, 2); | ||
| input.Insert(index, | ||
| new AnnotatedBytecodeInstruction(DreamProcOpcode.ReturnReferenceValue, | ||
| new List<IAnnotatedBytecode> { pushVal })); |
Check notice
Code scanning / InspectCode
Use collection expression syntax Note
wixoaGit
requested changes
Jun 19, 2024
wixoaGit
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PushReferenceValue, Return) -> ReturnReferenceValuePer my frequency analysis this pattern occurs ~16k times in Paradise and ~25k times in goon and TG. It is a top-ten offender on all codebases tested.
However, this optimization is heavily kneecapped by #1842 which causes it to only be applied 664 times in Paradise bytecode. Once that issue is fixed this will become much more significant, as a large number of procs will no longer modify their stack when they return.