Improvements to the CHILD control #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private Control? _leftElement, _rightElement; | ||
|
|
||
| public ControlChild(ControlDescriptor controlDescriptor, ControlWindow window) : base(controlDescriptor, window) { } | ||
| private Splitter _splitter; |
Check warning
Code scanning / InspectCode
Non-nullable member is uninitialized. Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CHILD control now uses a custom Splitter control rather than the SplitContainer provided by RT. This simplifies a lot of the code in
ControlChildand allows us to more closely emulate BYOND appearance and behavior.It now also has a color and border to more clearly separate panes.
Before:
After:
I also made the
top/bottomattributes alias toleft/rightas they do in BYOND. This fixes the top-left Text and Info buttons on Paradise.