Cache icon renders between frames #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Fixes plane transparency and filters, but leads to more memory allocation unfortunately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The texture for an atom is now only re-rendered once its appearance or animation frame changes. This same texture is reused between frames instead of performing the entire render process again. This leads to massive improvements in client performance, in both render times and allocation rate.
Observing this same spot on Paradise brought allocations per frame down ~350KB (~20.5MB per second at 60FPS!). FPS is more difficult to get a hard number for, but this brought it much closer to a stable 60FPS on my laptop's integrated graphics.
Before:
After:
Did a lot of playing around with things that led to some dirty code, so I'd like to clean things up some before merging. There are also some minor bugs (there are so many magic numbers & steps in the renderer) and I need to test how this plays withAll looks good.animate().