Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appearance Weakrefs #1815

Merged
merged 95 commits into from
Jan 5, 2025

Fix some NREs

1e54318
Select commit
Loading
Failed to load commit list.
Merged

Appearance Weakrefs #1815

Fix some NREs
1e54318
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / InspectCode succeeded Jan 5, 2025 in 6s

7 new alerts

New alerts in code changed by this pull request

  • 5 warnings
  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 561 in OpenDreamClient/Rendering/DreamIcon.cs

See this annotation in the file changed.

Code scanning / InspectCode

Struct with default equality members is used for comparison: Private accessibility Warning

Struct 'AppearanceAnimation' is checked for equality using an inefficient runtime-provided implementation

Check warning on line 194 in OpenDreamRuntime/DreamMapManager.cs

See this annotation in the file changed.

Code scanning / InspectCode

Possible unintended reference comparison. To get a value comparison, use 'Equals' method. Warning

Possible unintended reference comparison. To get a value comparison, use 'Equals' method.

Check warning on line 4 in OpenDreamRuntime/ServerContentIoC.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant using directive Warning

Using directive is not required by the code and can be safely removed

Check warning on line 143 in OpenDreamShared/Dream/ImmutableAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Equality comparison of floating point numbers. Possible loss of precision while rounding values Warning

Equality comparison of floating point numbers. Possible loss of precision while rounding values

Check warning on line 145 in OpenDreamShared/Dream/ImmutableAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Equality comparison of floating point numbers. Possible loss of precision while rounding values Warning

Equality comparison of floating point numbers. Possible loss of precision while rounding values

Check notice on line 12 in OpenDreamShared/Network/Messages/MsgNewAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Convert constructor into primary constructor Note

Convert into primary constructor

Check notice on line 16 in OpenDreamShared/Rendering/SharedDMISpriteComponent.cs

See this annotation in the file changed.

Code scanning / InspectCode

Convert constructor into primary constructor Note

Convert into primary constructor