Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement /database and /database/query #1802

Merged
merged 11 commits into from
Aug 19, 2024

Conversation

hry-gh
Copy link
Contributor

@hry-gh hry-gh commented May 21, 2024

hopefully! this probably needs work and a more comprehensive test suite - /database/query/Reset() isn't implemented because it seems a real ass

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label May 21, 2024
@@ -33,6 +33,8 @@
public TreeEntry Matrix { get; private set; }
public TreeEntry Exception { get; private set; }
public TreeEntry Savefile { get; private set; }
public TreeEntry Database { get; private set; }

Check warning

Code scanning / InspectCode

Non-nullable member is uninitialized. Warning

Non-nullable property 'Database' is uninitialized. Consider declaring the property as nullable.
@@ -33,6 +33,8 @@
public TreeEntry Matrix { get; private set; }
public TreeEntry Exception { get; private set; }
public TreeEntry Savefile { get; private set; }
public TreeEntry Database { get; private set; }
public TreeEntry DatabaseQuery { get; private set; }

Check warning

Code scanning / InspectCode

Non-nullable member is uninitialized. Warning

Non-nullable property 'DatabaseQuery' is uninitialized. Consider declaring the property as nullable.
@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label May 24, 2024
@@ -21,6 +21,8 @@
public static readonly DreamPath World = new DreamPath("/world");
public static readonly DreamPath Client = new DreamPath("/client");
public static readonly DreamPath Datum = new DreamPath("/datum");
public static readonly DreamPath Database = new DreamPath("/database");

Check notice

Code scanning / InspectCode

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification
@@ -21,6 +21,8 @@
public static readonly DreamPath World = new DreamPath("/world");
public static readonly DreamPath Client = new DreamPath("/client");
public static readonly DreamPath Datum = new DreamPath("/datum");
public static readonly DreamPath Database = new DreamPath("/database");
public static readonly DreamPath DatabaseQuery = new DreamPath("/database/query");

Check notice

Code scanning / InspectCode

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@hry-gh hry-gh marked this pull request as draft August 5, 2024 10:55
@hry-gh hry-gh marked this pull request as ready for review August 5, 2024 11:29
@wixoaGit wixoaGit merged commit 97e8841 into OpenDreamProject:master Aug 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants