Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a debug assert in DMProcState.PopDrop() #1693

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add a debug assert in DMProcState.PopDrop() #1693

merged 1 commit into from
Mar 1, 2024

Conversation

wixoaGit
Copy link
Member

@wixoaGit wixoaGit commented Mar 1, 2024

I saw that #1554 fixed a bug with the PopReference opcode being used where it shouldn't have been (the reference had already been popped from the stack). An assert in PopDrop() would have made this easier to catch.

@boring-cyborg boring-cyborg bot added the Runtime Involves the OpenDream server/runtime label Mar 1, 2024
@wixoaGit wixoaGit enabled auto-merge (squash) March 1, 2024 03:14
@wixoaGit wixoaGit merged commit e2a403f into OpenDreamProject:master Mar 1, 2024
7 checks passed
@wixoaGit wixoaGit deleted the popdrop_assert branch March 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Runtime Involves the OpenDream server/runtime size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wixoaGit