Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume parameter types based on type hints #1675

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Assume parameter types based on type hints #1675

merged 2 commits into from
Feb 18, 2024

Conversation

wixoaGit
Copy link
Member

This would previously be given a default as-type of anything:

/client/verb/attack(var/mob/M)

BYOND treats this as var/mob/M as mob so now we do too. I also fixed verbs with a target with the anything type, which were previously ignored.

@wixoaGit
Assume parameter type based on type hint
6402327 
Also fix verbs with `anything` as-type targets
@wixoaGit
Fix a nullability bug
4cb5ae8
@boring-cyborg boring-cyborg bot added Client Involves the OpenDream client Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime labels Feb 18, 2024
@wixoaGit wixoaGit merged commit 7b16a79 into OpenDreamProject:master Feb 18, 2024
7 checks passed
@wixoaGit wixoaGit deleted the assume_parameter_type branch February 18, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client Involves the OpenDream client Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wixoaGit