Remove obsolete Error() in DMParser
#1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix some warnings
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Remove a parameter only used by one thing and remove a try/finally
…rror_uses # Conflicts: # DMCompiler/DM/Builders/DMProcBuilder.cs
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…rror_uses # Conflicts: # DMCompiler/Compiler/DM/DMParser.cs # DMCompiler/DM/Builders/DMProcBuilder.cs
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
JumpIfTrue JumpIfNullDereference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all the uses of the obsolete
Error(string message, bool throwException = true)in the compiler. Parsing errors no longer throw/catch aCompileErrorExceptionand error handling should be generally more flexible. This also brings the total warnings when building DMCompiler from 338 to 173 (down 165).Will need more testing to make sure error handling is in a good place.