Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start work on set src and atom-as-a-first-arg in verbs #1668

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

wixoaGit
Copy link
Member

@wixoaGit wixoaGit commented Feb 10, 2024

Started work on set src, currently just supports set src = usr.

Also started recognizing what I called the "target arg" in verbs. If the verb's first argument takes an atom-type then it will show up in the right click menu of those targets. This gets the right click menu a lot closer to BYOND's behavior.

Also added support for new /obj/verb/foo(src). Closes #1077.

@boring-cyborg boring-cyborg bot added Client Involves the OpenDream client Runtime Involves the OpenDream server/runtime labels Feb 10, 2024
These were undocumented values.

Also made `set src in world/usr` implicitly convert into `set src = world/usr.contents`
@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Feb 10, 2024
In BYOND client verbs are always visible but only executable if src is usr or world. We'll just ignore it entirely.
@github-actions github-actions bot added size/XL and removed size/L labels Feb 12, 2024
@wixoaGit wixoaGit merged commit 6e250f8 into OpenDreamProject:master Feb 12, 2024
7 checks passed
@wixoaGit wixoaGit deleted the set_src branch March 25, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Involves the OpenDream client Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using new with procs/verbs
1 participant