Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize AST definitions #1644

Merged
merged 16 commits into from
Feb 12, 2024
Merged

Conversation

wixoaGit
Copy link
Member

AST definitions were organized into several files:

  • DMAST.cs
  • DMAST.Expression.cs
  • DMAST.ExpressionConstant.cs
  • DMAST.ExpressionUnary.cs
  • DMAST.ExpressionBinary.cs
  • DMAST.ObjectStatements.cs
  • DMAST.ProcStatements.cs

They were also made to use C#'s new primary constructors which makes them much more compact and readable. The visitor pattern has also finally been removed.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Feb 10, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

# Conflicts:
#	DMCompiler/Compiler/DM/DMAST.cs
#	DMCompiler/DM/Visitors/DMASTSimplifier.cs
@wixoaGit wixoaGit merged commit 9e11562 into OpenDreamProject:master Feb 12, 2024
7 checks passed
@wixoaGit wixoaGit deleted the organize_ast branch February 12, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler Involves the OpenDream compiler size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant