Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay blending multiplying for transparent alpha #1577

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

itsmeow
Copy link
Contributor

@itsmeow itsmeow commented Dec 30, 2023

BYOND seems to just copy the source RGB if the destination is 0 alpha, rather than doing multiplication by the source alpha.

/world
	fps = 25
	icon_size = 32
	view = 1

/mob/verb/Y()
	set name = "Y"
	var/atom/movable/Z = new (loc)
	var/icon/A = icon('transparent.dmi', "nothing")
	A.Blend(icon('transparent.dmi', "thing"), ICON_OVERLAY)
	Z.icon = A

BYOND result:
image

OpenDream result (old) - see how it's desaturated/darker?
image

OpenDream result (new) - no longer desaturated.
image

@itsmeow itsmeow changed the title Fix overlay blending multiplying for transparnet alpha Fix overlay blending multiplying for transparent alpha Dec 30, 2023
@wixoaGit wixoaGit merged commit 94ceaba into OpenDreamProject:master Jan 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants