Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ACZ fixes (#1573)" #1574

Merged
merged 1 commit into from
Dec 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions OpenDreamPackaging/DreamPackaging.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using Robust.Packaging;
using Robust.Packaging.AssetProcessing;
using Robust.Packaging.AssetProcessing.Passes;

namespace OpenDreamPackaging;

Expand All @@ -20,21 +19,13 @@ public static async Task WriteResources(

var inputPass = graph.Input;

await RobustSharedPackaging.WriteContentAssemblies(
inputPass,
await RobustClientPackaging.WriteClientResources(
contentDir,
"Content.Client",
new[] { "OpenDreamClient", "OpenDreamShared" },
cancel: cancel);
inputPass,
cancel);

await RobustClientPackaging.WriteClientResources(contentDir, inputPass, cancel);

WriteRscResources(dreamRootDir, resources, inputPass);

inputPass.InjectFinished();
}

public static void WriteRscResources(string dreamRootDir, string[] resources, AssetPassPipe inputPass) {
for (var i = 0; i < resources.Length; i++) {
var resource = resources[i].Replace('\\', Path.DirectorySeparatorChar);
// The game client only knows a resource ID, so that's what we name the files.
Expand All @@ -44,5 +35,7 @@ public static void WriteRscResources(string dreamRootDir, string[] resources, As

inputPass.InjectFileFromDisk(path, diskPath);
}

inputPass.InjectFinished();
}
}
43 changes: 0 additions & 43 deletions OpenDreamRuntime/DreamAczProvider.cs

This file was deleted.

26 changes: 26 additions & 0 deletions OpenDreamRuntime/DreamMagicAczProvider.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
using System.Threading;
using System.Threading.Tasks;
using OpenDreamPackaging;
using Robust.Packaging;
using Robust.Packaging.AssetProcessing;
using Robust.Server.ServerStatus;

namespace OpenDreamRuntime;

public sealed class DreamMagicAczProvider : IMagicAczProvider {
private readonly IDependencyCollection _dependencies;
private readonly string _rootPath;
private readonly string[] _resources;

public DreamMagicAczProvider(IDependencyCollection dependencies, string rootPath, string[] resources) {
_dependencies = dependencies;
_rootPath = rootPath;
_resources = resources;
}

public async Task Package(AssetPass pass, IPackageLogger logger, CancellationToken cancel) {
var contentDir = DefaultMagicAczProvider.FindContentRootPath(_dependencies);

await DreamPackaging.WriteResources(contentDir, _rootPath, _resources, pass, logger, cancel);
}
}
8 changes: 4 additions & 4 deletions OpenDreamRuntime/DreamManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public bool LoadJson(string? jsonPath) {
}

_compiledJson = json;
var rootPath = Path.GetFullPath(Path.GetDirectoryName(jsonPath)!);
var rootPath = Path.GetDirectoryName(jsonPath)!;
var resources = _compiledJson.Resources ?? Array.Empty<string>();
_dreamResourceManager.Initialize(rootPath, resources);
if(!string.IsNullOrEmpty(_compiledJson.Interface) && !_dreamResourceManager.DoesFileExist(_compiledJson.Interface))
Expand Down Expand Up @@ -146,9 +146,9 @@ public bool LoadJson(string? jsonPath) {

_dreamMapManager.LoadMaps(_compiledJson.Maps);

var aczProvider = new DreamAczProvider(_dependencyCollection, rootPath, resources);
_statusHost.SetMagicAczProvider(aczProvider);
_statusHost.SetFullHybridAczProvider(aczProvider);
_statusHost.SetMagicAczProvider(new DreamMagicAczProvider(
_dependencyCollection, rootPath, resources
));

return true;
}
Expand Down
4 changes: 4 additions & 0 deletions OpenDreamRuntime/EntryPoint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ public sealed class EntryPoint : GameServer {
private DreamCommandSystem? _commandSystem;

public override void Init() {
IoCManager.Resolve<IStatusHost>().SetMagicAczProvider(new DefaultMagicAczProvider(
new DefaultMagicAczInfo("Content.Client", new[] {"OpenDreamClient", "OpenDreamShared"}),
IoCManager.Resolve<IDependencyCollection>()));

IComponentFactory componentFactory = IoCManager.Resolve<IComponentFactory>();
componentFactory.DoAutoRegistrations();

Expand Down
2 changes: 1 addition & 1 deletion RobustToolbox
Submodule RobustToolbox updated 91 files
+1 −1 MSBuild/Robust.Engine.Version.props
+1 −61 RELEASE-NOTES.md
+74 −155 Robust.Benchmarks/Transform/RecursiveMoveBenchmark.cs
+0 −44 Robust.Client.WebView/Cef/Program.cs
+0 −5 Robust.Client.WebView/Cef/WebViewManagerCef.cs
+7 −20 Robust.Client/GameObjects/ClientEntityManager.cs
+5 −54 Robust.Client/GameObjects/Components/Renderable/SpriteComponent.cs
+6 −2 Robust.Client/GameObjects/EntitySystems/ClientOccluderSystem.cs
+9 −8 Robust.Client/GameObjects/EntitySystems/PointLightSystem.cs
+1 −1 Robust.Client/GameStates/ClientDirtySystem.cs
+15 −55 Robust.Client/UserInterface/Controls/SpriteView.cs
+2 −2 Robust.Server/Audio/AudioSystem.Effects.cs
+2 −1 Robust.Server/Audio/AudioSystem.cs
+9 −26 Robust.Server/Console/ServerConsoleHost.cs
+2 −2 Robust.Server/GameObjects/EntitySystems/InputSystem.cs
+0 −7 Robust.Server/GameObjects/EntitySystems/MapSystem.cs
+0 −15 Robust.Server/GameObjects/EntitySystems/PointLightSystem.cs
+0 −23 Robust.Server/GameObjects/EntitySystems/ServerOccluderSystem.cs
+20 −46 Robust.Server/GameObjects/EntitySystems/VisibilitySystem.cs
+8 −2 Robust.Server/GameObjects/ServerEntityManager.cs
+91 −0 Robust.Server/GameStates/PVSData.cs
+0 −277 Robust.Server/GameStates/PvsChunk.cs
+673 −0 Robust.Server/GameStates/PvsCollection.cs
+0 −192 Robust.Server/GameStates/PvsData.cs
+34 −171 Robust.Server/GameStates/PvsOverrideSystem.cs
+11 −39 Robust.Server/GameStates/PvsSystem.Ack.cs
+0 −338 Robust.Server/GameStates/PvsSystem.Chunks.cs
+15 −3 Robust.Server/GameStates/PvsSystem.Dirty.cs
+0 −114 Robust.Server/GameStates/PvsSystem.Entity.cs
+71 −15 Robust.Server/GameStates/PvsSystem.GetStates.cs
+0 −190 Robust.Server/GameStates/PvsSystem.Overrides.cs
+0 −39 Robust.Server/GameStates/PvsSystem.Pooling.cs
+0 −125 Robust.Server/GameStates/PvsSystem.Session.cs
+214 −149 Robust.Server/GameStates/PvsSystem.ToSendSet.cs
+758 −154 Robust.Server/GameStates/PvsSystem.cs
+197 −0 Robust.Server/GameStates/RobustTree.cs
+242 −25 Robust.Server/GameStates/ServerGameStateManager.cs
+10 −7 Robust.Server/Replays/ReplayRecordingManager.cs
+0 −30 Robust.Server/ServerStatus/IFullHybridAczProvider.cs
+0 −25 Robust.Server/ServerStatus/IStatusHost.cs
+11 −31 Robust.Server/ServerStatus/StatusHost.Acz.Sources.cs
+9 −17 Robust.Server/ServerStatus/StatusHost.Acz.cs
+0 −2 Robust.Shared.Scripting/ScriptGlobalsShared.cs
+2 −16 Robust.Shared/CVars.cs
+0 −5 Robust.Shared/Console/ConsoleHost.cs
+1 −1 Robust.Shared/Containers/SharedContainerSystem.Insert.cs
+2 −0 Robust.Shared/Containers/SharedContainerSystem.Remove.cs
+3 −0 Robust.Shared/Containers/SharedContainerSystem.Validation.cs
+0 −5 Robust.Shared/GameObjects/Components/Eye/EyeComponent.cs
+0 −23 Robust.Shared/GameObjects/Components/MetaDataComponent.cs
+0 −2 Robust.Shared/GameObjects/Components/Renderable/SpriteLayerData.cs
+25 −23 Robust.Shared/GameObjects/Components/Transform/TransformComponent.cs
+0 −2 Robust.Shared/GameObjects/Entity.cs
+9 −87 Robust.Shared/GameObjects/EntityManager.cs
+2 −2 Robust.Shared/GameObjects/EntityStringRepresentation.cs
+15 −30 Robust.Shared/GameObjects/EntitySystem.Proxy.cs
+7 −2 Robust.Shared/GameObjects/EntitySystemMessages/EntityTerminatingEvent.cs
+2 −2 Robust.Shared/GameObjects/IComponent.cs
+1 −21 Robust.Shared/GameObjects/IEntityManager.cs
+0 −3 Robust.Shared/GameObjects/NetEntity.cs
+1 −4 Robust.Shared/GameObjects/Systems/EntityLookupSystem.cs
+3 −10 Robust.Shared/GameObjects/Systems/MetaDataSystem.cs
+2 −2 Robust.Shared/GameObjects/Systems/OccluderSystem.cs
+14 −34 Robust.Shared/GameObjects/Systems/SharedGridTraversalSystem.cs
+15 −15 Robust.Shared/GameObjects/Systems/SharedMapSystem.Grid.cs
+6 −20 Robust.Shared/GameObjects/Systems/SharedPointLightSystem.cs
+7 −7 Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs
+0 −20 Robust.Shared/GameStates/GameState.cs
+1 −29 Robust.Shared/Localization/ILocalizationManager.cs
+52 −189 Robust.Shared/Localization/LocalizationManager.cs
+0 −1 Robust.Shared/Map/IMapManager.cs
+21 −75 Robust.Shared/Map/MapManager.Queries.cs
+3 −1 Robust.Shared/Network/Messages/MsgState.cs
+1 −1 Robust.Shared/Physics/Systems/SharedBroadphaseSystem.cs
+2 −1 Robust.Shared/Player/ISharedPlayerManager.cs
+21 −6 Robust.Shared/Player/SharedPlayerManager.State.cs
+2 −2 Robust.Shared/Replays/SharedReplayRecordingManager.cs
+1 −1 Robust.Shared/Toolshed/Commands/Entities/DoCommand.cs
+0 −3 Robust.Shared/Toolshed/Commands/Generic/EmplaceCommand.cs
+0 −3 Robust.Shared/Toolshed/Commands/Generic/ReduceCommand.cs
+1 −7 Robust.Shared/Toolshed/IInvocationContext.cs
+5 −10 Robust.Shared/Toolshed/Invocation/OldShellInvocationContext.cs
+13 −34 Robust.Shared/Toolshed/ToolshedManager.cs
+1 −10 Robust.UnitTesting/RobustIntegrationTest.NetManager.cs
+1 −5 Robust.UnitTesting/RobustUnitTest.cs
+0 −153 Robust.UnitTesting/Server/GameStates/PvsChunkTest.cs
+2 −7 Robust.UnitTesting/Server/RobustServerSimulation.cs
+6 −6 Robust.UnitTesting/Shared/GameObjects/ContainerTests.cs
+6 −6 Robust.UnitTesting/Shared/Map/EntityCoordinates_Tests.cs
+0 −3 Robust.UnitTesting/Shared/Toolshed/ToolshedTest.cs
+1 −5 Robust.UnitTesting/TestingParallelManager.cs
Loading