Makes client.images respect changes
#1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amylizzle
changed the title
/image to vis_contents/image to vis_contents and makes client.images respect changes
|
Note: tested on paradise as AI, performance is great. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
amylizzle
changed the title
/image to vis_contents and makes client.images respect changesclient.images respect changes
|
Can't replicate that weird effect at all. Can you still? |
I cannot. Appears to be a one-off unrelated graphical glitch. |
wixoaGit
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a temporary entity for the image, attaches the appearance to that.
Fixes #1422
Minor concern is that entities are too expensive though.No they're not, tested on Paradise as AI and it was smooth as butter.