Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] implement datum saving #1546

Closed
wants to merge 19 commits into from
Closed

Conversation

LetterN
Copy link
Contributor

@LetterN LetterN commented Dec 5, 2023

Title. implements how the Read() and Write() work

resolves #1303
resolves #1305
resolves #1306

requires #1535

currently nothing is being written on savefile(?) as asserts accessing fails S["mapdata/.0/type"]

@LetterN LetterN marked this pull request as draft December 5, 2023 05:42
@LetterN LetterN marked this pull request as ready for review December 6, 2023 04:57
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

# Conflicts:
#	OpenDreamRuntime/Objects/Types/DreamObjectSavefile.cs
@LetterN LetterN changed the title implement datum saving [DNM] implement datum saving Dec 23, 2023
@LetterN LetterN marked this pull request as draft January 6, 2024 11:40
LetterN and others added 2 commits January 14, 2024 20:10
* start

* premerge

* todo a bunch of recursive bullshit

* stub import

* broken test plus some stuff, todo: lots

* fix test

* pathing is wrong but it's closer. Also I stole DreamObjectSavefile from LetterN's PR

* stuff
@LetterN LetterN closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants