Improves error emission of switch blocks, adds new pragma #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Altoids1
force-pushed
the
better-switch-errors
branch
2 times, most recently
from
7e4792b to
d4ac056
Compare
Turns out, BYOND actually is OK with "else if" appearing in a switch block, but takes it to mean an 'else' of the switch, followed by an if-elseif-else ladder within that case block. Beestation apparently uses this in production, but it's a very odd and ambiguous style (Ike told me he had to fix a bug caused by this recently in Para) so I've made a style warning for it. This patch also includes some auditing of DMParser Error() emissions so that switch case parsing throws exceptions less often (which reduces code skipping). I do not love how git submodules work edit: was missing one comma
DMParser should be emitting actual error codes and avoiding throwing when possible (so as to minimize code-skipping).
Altoids1
force-pushed
the
better-switch-errors
branch
from
d4ac056 to
e3a78a2
Compare
wixoaGit
requested changes
Aug 8, 2023
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # DMCompiler/DMStandard/DefaultPragmaConfig.dm # OpenDreamShared/Compiler/CompilerError.cs
wixoaGit
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #996.
Summary
Quick and easy audit of our switch parsing, to make use of the new(ish) pragma system.
Changelog
SuspiciousSwitchCase, for when user codebases useelse ifas a switch case (which is valid but is read as an 'else' case block with an if block inside it)base.Error()is now marked as obsolete. All calls of that nature should be rewritten to make use of the pragma system and not necessitate throwing, whenever possible (to minimize code skips).